Add GLIBC_2.0 symbol version support for loongarch64 manylinux policies #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…policies Signed-off-by: 吴小白 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 80.66% 79.22% -1.44%
==========================================
Files 22 22
Lines 1815 1815
Branches 338 338
==========================================
- Hits 1464 1438 -26
- Misses 269 292 +23
- Partials 82 85 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes compatibility issues with wheels built for loongarch64
architecture that contain GLIBC_2.0 versioned symbols. The patch adds
GLIBC_2.0 to the allowed symbol versions for all loongarch64 manylinux
policies:
Problem:
Wheel repair was failing with errors like:
"Package requires GLIBC_2.0, incompatible with policy manylinux_2_38_loongarch64"
This occurred because certain libraries (particularly libgcc_s.so.1) still
reference the legacy GLIBC_2.0 symbol version, which was not included in
the loongarch64 policy definitions.
Solution:
Add GLIBC_2.0 to the GLIBC symbol version whitelist for loongarch64
targets, matching the symbol version support already present in other
architecture policies.
This change enables successful wheel repair for packages containing
legacy GLIBC_2.0 symbols while maintaining compatibility with the
respective manylinux standards.